Add .go-version and .golangci.yml #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
force-pushed
the
feature/golangci-lint
branch
from
61851aa
to
d9c5394
Compare
andrewkroh
force-pushed
the
feature/golangci-lint
branch
from
839341a
to
3f52eb8
Compare
Enable golangci-lint and specify the Go version in a .go-version file.
Update the Go version used to build the binary in the Docker image. Use dependencies from the runtime image rather than copying them from the build image. This was holdover from when we used to distribute an image built `FROM scratch`.
andrewkroh
force-pushed
the
feature/golangci-lint
branch
from
3f52eb8
to
26c4b80
Compare
efd6
approved these changes
Feb 24, 2022
| # If you're going to write a comment follow the conventions. | ||
| # https://go.dev/doc/effective_go#commentary. | ||
| # comment on exported (.+) should be of the form "(.+)..." | ||
| - EXC0014 |
There was a problem hiding this comment.
Note that this is also ST1021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable golangci-lint and specify the Go version in a .go-version file.