Skip response parsing for raw requests #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we skip response parsing for raw requests. As users might leverage the `raw-request` operation type for any kind of request, it is possible that it produces arbitrarily large responses, which might introduce client-side bottlenecks. As we don't inspect the response body, we might as well just use the raw response internally and avoid an accidental bottleneck due to response parsing.
danielmitterdorfer
added
enhancement
michaelbaamonde
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
The reasoning makes sense to me. Thanks @danielmitterdorfer!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we skip response parsing for raw requests. As users might leverage the
raw-requestoperation type for any kind of request, it is possible that it produces arbitrarily large responses, which might introduce client-side bottlenecks. As we don't inspect the response body, we might as well just use the raw response internally and avoid an accidental bottleneck due to response parsing.