Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links on README.md #1552

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Fix broken links on README.md #1552

merged 1 commit into from
Aug 1, 2022

Conversation

pakio
Copy link
Contributor

@pakio pakio commented Jul 29, 2022

This PR is to fix the broken link on README.md, tried to reproduce README.rst as much as possible.

@pquentin
Copy link
Member

@elasticmachine run tests please

pquentin
pquentin approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this and fixing it! This looks good to me.

michaelbaamonde
michaelbaamonde approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too. Many thanks, @pakio!

@michaelbaamonde michaelbaamonde merged commit e115eda into elastic:master Aug 1, 2022
@pakio pakio deleted the fix-link-on-readme branch August 2, 2022 00:14
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
@pquentin pquentin added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. :Docs Changes to the documentation and removed :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbaamonde michaelbaamonde michaelbaamonde approved these changes

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
:Docs Changes to the documentation
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pakio @pquentin @michaelbaamonde