Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly log how long it took to close transports #1539

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Correctly log how long it took to close transports #1539

merged 1 commit into from
Jul 8, 2022

Conversation

michaelbaamonde
Copy link
Contributor

The load driver incorrectly logs a negative number when reporting how long it took to shut down transports. Example:

2022-07-07 14:49:27,475 ActorAddr-(T|:37235)/PID:2900742 esrally.driver.driver INFO Total time to close transports: -0.000971 seconds.

This PR fixes this, resulting in logs like this:

2022-07-07 14:56:28,700 ActorAddr-(T|:40609)/PID:2902950 esrally.driver.driver INFO Total time to close transports: 0.000797 seconds.

@michaelbaamonde michaelbaamonde added bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc. cleanup Linter changes, reformatting, removal of unused code etc. labels Jul 7, 2022
pquentin
pquentin approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so this was the issue! I've always wondered. Thanks.

@michaelbaamonde michaelbaamonde merged commit 3d8d7bc into elastic:master Jul 8, 2022
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
bug Something's wrong cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbaamonde @pquentin