Explicit offline mode #1503
Merged
Explicit offline mode #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bennet
commented
May 27, 2022
pquentin
requested changes
May 31, 2022
|
|
||
| @it.rally_in_mem | ||
| def test_run_without_http_connection(cfg): | ||
| cmd = it.esrally_command_line_for(cfg, "list races") |
There was a problem hiding this comment.
What the... I had no idea we sent a request to GitHub for every single invocation, even when just listing races. This makes esrally list races 1.4s slower for me!
There was a problem hiding this comment.
It would be a nice thing to fix, probably in a separate PR, don't you think? I'm sure lots of commands don't need Rally to be online.
There was a problem hiding this comment.
Opened an issue so it's not forgotten: #1506.
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1468.
In case there's no internet connection, exit and suggest using
--offlinemode, as opposed to falling back to offline mode without asking.Added an integration test as well.