This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
[snapshot] Update package-registry to 0.9.0 #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI error unrelated:
|
mtojek
changed the title
Update package-registry to 0.9.0
[snapshot] Update package-registry to 0.9.0
Aug 4, 2020
ruflin
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I did rerun CI. I really wonder why always the netflow package fails?
... and with different errors :D |
ycombinator
reviewed
Aug 4, 2020
@@ -8,6 +8,8 @@ github.com/elastic/go-ucfg v0.8.4-0.20200415140258-1232bd4774a6 h1:Ehbr7du4rSSEy | |||
github.com/elastic/go-ucfg v0.8.4-0.20200415140258-1232bd4774a6/go.mod h1:iaiY0NBIYeasNgycLyTvhJftQlQEUO2hpF+FX0JKxzo= | |||
github.com/elastic/package-registry v0.7.0 h1:32fAVDQNNJ+mE/8zVNXfUCPX99Z6DLghmPkI4YZBhRA= | |||
github.com/elastic/package-registry v0.7.0/go.mod h1:ERTTIxAsQOCVZJDqR4LJbDDAtxV+pz4wdPPrKheiAUc= | |||
github.com/elastic/package-registry v0.9.0 h1:bfVF5k6w43zjYaF+0t3fRCU1IguRhwqeY1wjG1LMA6k= | |||
github.com/elastic/package-registry v0.9.0/go.mod h1:oQx3Tg9ynuC6APd0o0OHud9kyPX6S6IzdJp/R4Hj1HY= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: run go mod tidy
to clean up older versions of dependencies in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have a mage registry update command that chains these commands together?
thomasneirynck
pushed a commit
to thomasneirynck/package-storage
that referenced
this pull request
Sep 28, 2021
* Fix path to apache logo * Fix path to docker logo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the package-registry to version 0.9.0.