Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monitoring_infrastructure category from package spec #490

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

jen-huang
Copy link
Contributor

What does this PR do?

Related to elastic/package-registry#970. With the deprecation of parent Infrastructure category, remove monitoring_infrastructure category as no integrations are currently using it.

@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-15T14:52:17.100+0000

  • Duration: 10 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 706
Skipped 0
Total 706

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 68.0% (17/25) 👍
Classes 76.471% (26/34) 👍
Methods 56.075% (60/107) 👍
Lines 41.933% (538/1283) 👍
Conditionals 100.0% (0/0) 💚

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be released as breaking change, possibly in a new minor.

spec/changelog.yml Outdated Show resolved Hide resolved
spec/changelog.yml Outdated Show resolved Hide resolved
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@jen-huang jen-huang changed the title Remove monitoring_infrastructure category Remove monitoring_infrastructure category from package spec Mar 15, 2023
@jen-huang jen-huang requested a review from jsoriano March 15, 2023 14:59
@jen-huang jen-huang merged commit d8652a1 into main Mar 15, 2023
@jen-huang jen-huang deleted the remove-monitoring-infrastructure branch March 15, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants