Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Advanced Analytics (UEBA) package subcategory under Security category #997

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Add Advanced Analytics (UEBA) package subcategory under Security category #997

merged 3 commits into from
Apr 28, 2023

Conversation

susan-shu-c
Copy link
Member

@susan-shu-c susan-shu-c mentioned this pull request Apr 26, 2023
Closed
8 tasks
@susan-shu-c susan-shu-c changed the title Add subcategory - "Advanced Analytics (UEBA)" under Security category Add Advanced Analytics (UEBA) package subcategory under Security category Apr 26, 2023
@susan-shu-c susan-shu-c requested a review from mrodm April 26, 2023 19:35
@elasticmachine
Copy link

elasticmachine commented Apr 26, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-26T19:27:09.608+0000

  • Duration: 10 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 488
Skipped 0
Total 488

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mrodm mrodm requested a review from a team April 27, 2023 08:01
jsoriano
jsoriano approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as Jen also seems to be fine with adding the category (elastic/package-spec#499 (comment)), and implementation looks good.

mrodm
mrodm approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susan-shu-c susan-shu-c merged commit f1b859c into main Apr 28, 2023
@mrodm mrodm deleted the susan/add-subcategory branch May 2, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodm mrodm mrodm approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@susan-shu-c @elasticmachine @jsoriano @mrodm