Fix headers forwarding when forwarding artifacts requests to the package storage #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
approved these changes
Dec 7, 2022
| file: "1password-logo-light-bg.svg.response", | ||
| responseHeaders: map[string]string{ | ||
| "Last-Modified": "time", | ||
| "Content-Type": "image/svg+xml", |
There was a problem hiding this comment.
Thanks for adding this to the tests 👍
Comment on lines
+43
to
+44
| // Set headers before setting the body. If not, first call to w.Write will | ||
| // add some default values. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing the headers forwarding after writing the body, but
ResponseWriter.Write()can set its own headers when others are not found.Set the headers before doing any write in the response.