-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow template_path
field on inputs
#655
Conversation
Follow up to elastic/package-spec#79. Kibana needs `template_path` to ascertain which input template file to read from to build the agent YAML. This PR lets the registry serve that field at the input level, if defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a new test package with relevant data stream to the testdata/package
directory? You can test it with go test .
. You will also need to regenerate expected data with go test . -generate
.
Please also add a CHANGELOG entry.
@mtojek Thanks, I added |
Follow up to elastic/package-spec#79. Kibana needs
template_path
to ascertain which input template file to read from to build the agent YAML. This PR lets the registry serve that field at the input level, if defined.