Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config template to policy template and dataset to datastream #641

Merged

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Sep 28, 2020

This PR renames config templates to policy templates and datasets to datastreams.

I regenerated golden files.

@mtojek mtojek self-assigned this Sep 28, 2020
@mtojek mtojek marked this pull request as draft September 28, 2020 11:24
@elasticmachine
Copy link

elasticmachine commented Sep 28, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #641 updated]

  • Start Time: 2020-09-30T12:17:44.231+0000

  • Duration: 7 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 161
Skipped 0
Total 161

type Dataset struct {
// Name and type of the dataset. This is linked to dataset.name and dataset.type fields.
type DataStream struct {
// Name and type of the dataStream. This is linked to dataStream.name and dataStream.type fields.
Type string `config:"type" json:"type" validate:"required"`
Name string `config:"name" json:"name,omitempty" yaml:"name,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding it! I'm looking into this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ycombinator
Copy link
Contributor

Nit: s/dataset/data stream/ in:

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek
Copy link
Contributor Author

mtojek commented Sep 30, 2020

testdata/package/datasources/1.0.0/dataset/examplemetric/manifest.yml

Thanks, fixed!

@mtojek mtojek merged commit dd7b021 into elastic:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants