-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename config template to policy template and dataset to datastream #641
Rename config template to policy template and dataset to datastream #641
Conversation
util/data_stream.go
Outdated
type Dataset struct { | ||
// Name and type of the dataset. This is linked to dataset.name and dataset.type fields. | ||
type DataStream struct { | ||
// Name and type of the dataStream. This is linked to dataStream.name and dataStream.type fields. | ||
Type string `config:"type" json:"type" validate:"required"` | ||
Name string `config:"name" json:"name,omitempty" yaml:"name,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
should be dataset
following https://github.com/elastic/package-spec/pull/24/files#diff-13d2900dcce8e312a06c834b665816a1R71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding it! I'm looking into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Nit: s/dataset/data stream/ in: package-registry/testdata/package/datasources/1.0.0/dataset/examplemetric/manifest.yml Line 1 in 868db07
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks, fixed! |
This PR renames config templates to policy templates and datasets to datastreams.
I regenerated golden files.