Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbers in package names #614

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Allow numbers in package names #614

merged 2 commits into from
Aug 3, 2020

Conversation

adriansr
Copy link
Contributor

Fixes #613

@elasticmachine
Copy link

elasticmachine commented Jul 30, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Adrian Serrano, Replayed #2]

  • Start Time: 2020-08-03T13:21:10.493+0000

  • Duration: 8 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 161
Skipped 0
Total 161

@adriansr adriansr mentioned this pull request Jul 30, 2020
Merged
2 tasks
@adriansr adriansr requested review from mtojek and ruflin July 30, 2020 16:11
@mtojek
Copy link
Contributor

mtojek commented Jul 30, 2020

FYI @ycombinator

andrewkroh
andrewkroh approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruflin
ruflin approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a changelog entry?

@ruflin
Copy link
Member

ruflin commented Jul 31, 2020

@adriansr As soon as this land, we might think about releasing a new version and adding it to the builds, see https://github.com/elastic/package-storage#update-package-registry-for-a-distribution We could also just get it into snapshot for to get the packages in and rollout a fully new version later. You can use the commit id for the container name.

@ruflin
Copy link
Member

ruflin commented Aug 3, 2020

jenkins, test this

@adriansr Somehow CI seems to be hanging :-(

@adriansr adriansr merged commit 4bd9675 into elastic:master Aug 3, 2020
@adriansr adriansr deleted the numbers_in_packages_are_cool branch August 3, 2020 13:32
@adriansr adriansr mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees
No one assigned
Labels
discussion review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Registry 404s on packages whose name contains a number
5 participants
@adriansr @elasticmachine @mtojek @ruflin @andrewkroh