Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for requirements in package manifest #574

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Remove support for requirements in package manifest #574

merged 4 commits into from
Jul 1, 2020

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jun 30, 2020

This is replaced by conditions. In this PR, only the old code is removed.

@ruflin ruflin self-assigned this Jun 30, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #574 updated]

  • Start Time: 2020-07-01T13:33:44.292+0000

  • Duration: 7 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 163
Skipped 0
Total 163

@ruflin
Remove support for requirements in package manifest
fec0e7b 
This is replaced by conditions. In this PR, only the old code is removed.
@ruflin
update generated file
ab5ec94
@ruflin
fix test
b1d5d08
@ruflin ruflin force-pushed the remove-legacy-requirements-code branch from 1f6d71c to b1d5d08 Compare July 1, 2020 13:13
@ruflin ruflin requested a review from mtojek July 1, 2020 13:14
mtojek
mtojek approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nit-pick

CHANGELOG.md Outdated Show resolved Hide resolved
@ruflin ruflin merged commit e9dc95b into elastic:master Jul 1, 2020
@ruflin ruflin deleted the remove-legacy-requirements-code branch July 1, 2020 14:24
@ruflin ruflin mentioned this pull request Jul 1, 2020
Closed
@neptunian neptunian mentioned this pull request Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@ruflin ruflin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruflin @elasticmachine @mtojek