Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply rule: first package found served #546

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Apply rule: first package found served #546

merged 3 commits into from
Jun 24, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 24, 2020

This PR modified the EPR to serve package contents from the first found package path.

Sample: if the integrations project loads another path with packages, it should have priority comparing to the package-storage.

@mtojek mtojek requested a review from ruflin June 24, 2020 08:23
@mtojek mtojek self-assigned this Jun 24, 2020
ruflin
ruflin approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One day we need to build docs and document this ;-)

@elasticmachine
Copy link

elasticmachine commented Jun 24, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #546 updated]

  • Start Time: 2020-06-24T08:25:22.204+0000

  • Duration: 8 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 127
Skipped 0
Total 127

@mtojek mtojek merged commit 5b436bf into elastic:master Jun 24, 2020
@mtojek mtojek mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ruflin