Use BasePackage for search output data #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the `/search` output was manually built. This had the risk that the format of the package output and search output diverge but they should not. To prevent this, a BasePackage is introduced. The package is composed out of this BasePackage with additional fields. This change does not affect the output, only the order of the output.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
mtojek
approved these changes
Jun 23, 2020
| @@ -163,28 +163,12 @@ func getPackageOutput(packagesList map[string]map[string]util.Package) ([]byte, | |||
| } | |||
| sort.Strings(keys) | |||
|
|
|||
| var output []map[string]interface{} | |||
| var output []util.BasePackage | |||
|
|
|||
| for _, k := range keys { | |||
| parts := strings.Split(k, separator) | |||
| m := packagesList[parts[0]][parts[1]] | |||
There was a problem hiding this comment.
nit: is there is a need to check the number of parts here (in case if it's empty)?
There was a problem hiding this comment.
I also stumbled over this line when I did the change and I plan to follow up to make this nicer. There must be a better way here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the
/searchoutput was manually built. This had the risk that the format of the package output and search output diverge but they should not. To prevent this, a BasePackage is introduced. The package is composed out of this BasePackage with additional fields.This change does not affect the output, only the order of the output.