-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Elasticsearch requirement #516
Conversation
@jonathan-buttner This will probably also need an update to the Endpoint package. |
I think you should rollout this the other way round. First, make sure nobody uses/publishes the field, then remove it. What about existing packages? I think @jonathan-buttner raised a similar issue a day ago (backwards incompatible change). |
As the field has not effects I would consider this "nobody is using it" ;-) As it doesn't break any existing packages, I think it is fine to get this in first. For the existing packages already released, I would not touch them as additional data can be there but will not be used. |
Usage:
I agree with this approach :) |
@mtojek Will you take care of the integrations usage or should I open a PR there? |
So far I have not seen a package that would need to specify requirements for an Elasticsearch version as the Elasticsearch and Kibana version are tied together in the minor. Because of this removing support for Elasticsearch requirements for now. We can readd it later if we need. This also cleans up the existing packages to remove the mention of Elasticsearch and some other examples that were still around. As a follow up, integrations packages should be updated to get rid of the requirement. But more changes will happen to the requirements after elastic#515 is merged so perhaps we rather wait with this a bit more. This change should not break any existing packages.
18ea819
to
862d19f
Compare
Sure, I can help here. |
@mtojek Thanks |
Thanks! I'll make sure our repo is updated 👍 |
@mtojek as elastic/integrations#92 is merged, ok to get this one in? |
So far I have not seen a package that would need to specify requirements for an Elasticsearch version as the Elasticsearch and Kibana version are tied together in the minor. Because of this removing support for Elasticsearch requirements for now. We can readd it later if we need.
This also cleans up the existing packages to remove the mention of Elasticsearch and some other examples that were still around.
As a follow up, integrations packages should be updated to get rid of the requirement. But more changes will happen to the requirements after #515 is merged so perhaps we rather wait with this a bit more.
This change should not break any existing packages.