Validate version consistency #510
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
| baseDir := filepath.Base(p.BasePath) | ||
| versionDir, err := semver.Parse(baseDir) | ||
| if err != nil { | ||
| return nil // package content is not rooted in version directory |
There was a problem hiding this comment.
Do you expect us to support this long term or only at the moment?
There was a problem hiding this comment.
I planned to leave it there long term. I put this check just in case.
| return p.ValidateDatasets() | ||
| } | ||
|
|
||
| func (p *Package) validateVersionConsistency() error { | ||
| versionPackage, err := semver.Parse(p.Version) |
There was a problem hiding this comment.
You could use this one here:
package-registry/util/package.go
Line 38 in d4a6d00
There was a problem hiding this comment.
No, I couldn't. The Validate() method is called by Marshal(), so the mentioned field is not filled yet.
| @@ -32,10 +32,9 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| packagesBasePath string | |||
There was a problem hiding this comment.
Seems like we don't use this anymore? My initial intention with this was to be able to pass it as a flag to to the docker container on which directories it should read.
There was a problem hiding this comment.
I the next step I have a plan to support multiple sources of packages (exactly for the docker environment). I think we can leave it as is.
Issue: #509