-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use index templates v2 in package 'base' #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My assumption is that in packages and EPM we ONLY support v2 templates. Is this correct?
@@ -0,0 +1,148 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More general question we had around ingest-pipeline
directory. Should it be component_template
or component-template
? What is our rule? Any preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no opinion here, I followed the example of ingest-pipeline
.
(Kibana saved objects use hyphenation and not snake case, maybe that's how the initial format was derived even for assets that are not Kibana assets.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep the -
for now. The part where I stumbled over _
is in the ES API.
Yes. For a smooth developer experience this week the code in elastic/kibana#64305 will be able to install pre-built v1 templates that are in the |
@skh Conflict in the CHANGELOG. And because of my other PR, probably best rebase ... |
@@ -0,0 +1,148 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a rebase, this should become base/1.0.0/..
as the path.
Closed, see #392 |
base
over to index templates v2component-template
Do not merge before elastic/kibana#64305 has been merged, as the current EPM implementation can't handle pre-built v2 packages.