Skip to content

Conversation

fred-maussion
Copy link
Contributor

This pull request change the manual APM instrumentation to autoinstrumented to enable distributed tracing for outbound calls made in proxy mode.

Changes:

  • The http.Client in proxymode.go is now instrumented using apmhttp.WrapRoundTripper to automatically trace outbound requests.
  • The request context is propagated to the outbound calls
  • Remove manual apm.StartSpan calls in favor of the new automatic instrumentation.

@fred-maussion fred-maussion requested a review from a team as a code owner September 11, 2025 09:34
@prodsecmachine
Copy link

prodsecmachine commented Sep 11, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@fred-maussion fred-maussion changed the title #1423 : Autoinstrumentation for proxympode #1423 : Autoinstrumentation for proxymode Sep 11, 2025
@fred-maussion
Copy link
Contributor Author

After applying the modification we can now see the external call and enable the latency feature of the platform
image
image
image

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! LGMT but go.mod needs to be updated.

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsoriano jsoriano merged commit 26cb075 into elastic:main Sep 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants