Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse http client on storage resolver #1147

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Reuse http client on storage resolver #1147

merged 3 commits into from
Apr 5, 2024
+15 −3

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 21, 2024 •
edited
Loading

Reuses http client on storage resolves and sets a generous connect timeout to circuit-break on network issues.

Let's try to get memory profiles before applying this change.

@jsoriano jsoriano requested a review from a team February 21, 2024 10:14
@jsoriano jsoriano self-assigned this Feb 21, 2024
mrodm
mrodm approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano marked this pull request as ready for review April 5, 2024 16:33
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano merged commit 618c875 into elastic:main Apr 5, 2024
3 checks passed
@jsoriano jsoriano deleted the configure-http-client-proxy-resolver branch April 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodm mrodm mrodm approved these changes

Assignees

@jsoriano jsoriano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @mrodm