Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go runtime to 1.20.4 #1002

Merged
merged 3 commits into from
May 3, 2023
Merged

Update Go runtime to 1.20.4 #1002

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f631d5
Update go runtime to 1.20.4
mrodm May 3, 2023
373ceaa
Add changelog entry
mrodm May 3, 2023
74a9171
Update changelog entry
mrodm May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .go-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.20.3
1.20.4
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Bugfixes

* Update Go runtime to 1.20.3. [#987](https://github.com/elastic/package-registry/pull/987)
* Update Go runtime to 1.20.4. [#1002](https://github.com/elastic/package-registry/pull/1002)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to just keep one changelog entry for this, like:

* Update Go runtime to 1.20.4. [#1002](https://github.com/elastic/package-registry/pull/1002)

or maybe with the two PR links

* Update Go runtime to 1.20.4. [#987](https://github.com/elastic/package-registry/pull/987) [#1002](https://github.com/elastic/package-registry/pull/1002)

WDYT ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, keep a single entry for this. Having both links sounds good.


### Added

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# It expects packages to be mounted under /packages/package-registry or have a config file loaded into /package-registry/config.yml

# Build binary
ARG GO_VERSION=1.20.3
ARG GO_VERSION=1.20.4
FROM golang:${GO_VERSION} AS builder

COPY ./ /package-registry
Expand Down