Confirm the order of prereleases

While working on https://github.com/elastic/apm-server/issues/8491, I found an interesting problem: [are all prerelease tags comparable](https://github.com/mtojek/package-registry/blob/check-prerelease-order/packages/package_test.go#L272-L307)?

The package-spec allows for defining the prerelease part as tag + timestamp. Which rules should EPR follow to figure out which revision is the newest one.

Few "tricky" comparisons:

`8.5.0-preview-1111111111111` vs `8.5.0-preview-2111111`
`8.5.0-preview-1111111111111` vs `8.5.0-beta-1111111111111`

I guess that we have to apply more rules (first thoughts below) to the [IsNewerOrEqual](https://github.com/mtojek/package-registry/blob/check-prerelease-order/packages/package.go#L392) function like:
1. Compare timestamp when the prerelease starts with [rc/beta/preview](https://github.com/elastic/package-spec/blob/main/code/go/internal/validator/semantic/validate_prerelease.go#L20-L30).
2. [rc/beta/preview](https://github.com/elastic/package-spec/blob/main/code/go/internal/validator/semantic/validate_prerelease.go#L20-L30) has higher priority than SNAPSHOT/next.

BTW the APM team selected the `preview` tag as it seemed to be the most accurate for them.

Feel free to chime in, @jsoriano @mrodm.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Confirm the order of prereleases #859

mtojek
openedon Aug 4, 2022

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Confirm the order of prereleases #859

Description

mtojekopenedon Aug 4, 2022

Metadata