Refactor to DisablePackageValidation

main.go

@@ -46,7 +46,7 @@ func init() {
 	flag.StringVar(&address, "address", "localhost:8080", "Address of the package-registry service.")
 	// This flag is experimental and might be removed in the future or renamed
 	flag.BoolVar(&dryRun, "dry-run", false, "Runs a dry-run of the registry without starting the web service (experimental)")
-	flag.BoolVar(&util.EnablePackageValidation, "validate", false, "Validate package content")
+	flag.BoolVar(&util.PackageValidationDisabled, "disable-package-validation", false, "Disable package content validation")
 }
 
 type Config struct {
@@ -62,10 +62,6 @@ func main() {
 	log.Println("Package registry started.")
 	defer log.Println("Package registry stopped.")
 
-	if dryRun {
-		util.EnablePackageValidation = true // dry-run enables the package validation
-	}
-
 	config := mustLoadConfig()
 	packagesBasePaths := getPackagesBasePaths(config)
 	ensurePackagesAvailable(packagesBasePaths)

util/data_stream.go

@@ -185,7 +185,7 @@ func NewDataStream(basePath string, p *Package) (*DataStream, error) {
 }
 
 func (d *DataStream) Validate() error {
-	if !EnablePackageValidation {
+	if PackageValidationDisabled {
 		return nil
 	}
 

util/package.go

@@ -313,7 +313,7 @@ func collectAssets(pattern string) ([]string, error) {
 // Validate is called during Unpack of the manifest.
 // The validation here is only related to the fields directly specified in the manifest itself.
 func (p *Package) Validate() error {
-	if !EnablePackageValidation {
+	if PackageValidationDisabled {
 		return nil
 	}
 

util/packages.go

@@ -13,8 +13,8 @@ import (
 	"github.com/pkg/errors"
 )
 
-// EnablePackageValidation is a flag which can enable package content validation (package, data streams, assets, etc.).
-var EnablePackageValidation = true
+// PackageValidationDisabled is a flag which can disable package content validation (package, data streams, assets, etc.).
+var PackageValidationDisabled bool
 
 var packageList Packages