-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beatsauthextension] Add support for beats related ssl parameters to be used with otel-components #334
Conversation
/test |
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think it could do with a bit more test coverage, but otherwise LGTM.
can this PR be merged? |
I'm not super close to Beats these days, so I suggest we wait for @mauri870 to take another look before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding the extension directory into the depenabot configuration file as well https://github.com/elastic/opentelemetry-collector-components/blob/main/.github/dependabot.yml?
That would help to upgrade the testing distribution all at once. Thank you (sorry about not having written guidelines for that yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This extension supports beats' related client ssl parameters such as verification_mode , ca_trusted_fingerprint and ca_sha256 to be used with otel components using
extensions
Local Testing done as follows:
The
ca.crt
file contains a a self signed certificate. And whenca_trusted_fingerprint
is not used, the indexing fails. The indexing is successfull on passing correctca_trusted_fingerprint
.