Skip to content

Enhance service correlation doc #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2023
Merged

Enhance service correlation doc #2731

merged 4 commits into from
Mar 23, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Mar 8, 2023 •
edited
Loading

  • logs general correlation fields + filebeat setup
  • invite users to set service version + env

Checklist

  • should we also recommend setting service.version and environment in RUM agent too ? That would be consistent with other agents, especially if the environment filter is applied globally. Not for now, the per-agent config is buried and only used in k8s tutorial.
  • validate config for Go agent
  • validate config for Java agent
  • validate config for .net agent
  • validate config for Node.js agent
  • validate config for Python agent
  • validate config for Ruby agent

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

A documentation preview will be available soon:

@SylvainJuge SylvainJuge mentioned this pull request Mar 8, 2023
Closed
5 tasks
@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2023

This pull request does not have a backport label. Could you fix it @SylvainJuge? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 8, 2023
@SylvainJuge SylvainJuge mentioned this pull request Mar 8, 2023
Open
7 tasks
@SylvainJuge SylvainJuge marked this pull request as ready for review March 20, 2023 12:05
@SylvainJuge SylvainJuge requested a review from a team as a code owner March 20, 2023 12:05
bmorelli25
bmorelli25 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great. Should this be backported to 8.7?

@SylvainJuge SylvainJuge added backport-8.7 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Mar 23, 2023
@SylvainJuge SylvainJuge merged commit 0c1f052 into elastic:main Mar 23, 2023
@SylvainJuge SylvainJuge deleted the enhance-service-correlation-doc branch March 23, 2023 08:49
mergify bot pushed a commit that referenced this pull request Mar 23, 2023
@SylvainJuge @mergify
Enhance service correlation doc (#2731)
4a15431 
* logs general correlation fields + filebeat setup
* invite users to set service version + env

(cherry picked from commit 0c1f052)
@mergify mergify bot mentioned this pull request Mar 23, 2023
Merged
bmorelli25 pushed a commit that referenced this pull request Mar 23, 2023
@mergify @SylvainJuge
Enhance service correlation doc (#2731) (#2787)
084c6f4 
* logs general correlation fields + filebeat setup
* invite users to set service version + env

(cherry picked from commit 0c1f052)

Co-authored-by: SylvainJuge <sylvain.juge@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
backport-8.7 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SylvainJuge @bmorelli25