Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oblt-cli/version updatecli policy #85

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

reakaleek
Copy link
Member

No description provided.

@reakaleek reakaleek added the changelog:chore When you add a change that is not user-facing label Jul 9, 2024
@reakaleek reakaleek self-assigned this Jul 9, 2024
@reakaleek reakaleek requested a review from a team July 9, 2024 15:01
@@ -2,7 +2,7 @@
# https://www.updatecli.io/docs/core/compose/
policies:
- name: Handle default oblt-cli version
policy: ghcr.io/elastic/oblt-updatecli-policies/oblt-cli/version:0.0.2@sha256:dd79537aa64a28c57da351182a70a2a798e9b6c5eb55c243fdbd4f5bffe5133d
policy: ghcr.io/elastic/oblt-updatecli-policies/oblt-cli/version:0.0.3@sha256:8b996fc5e4351610117ad87e0cc74f562c8228c967a5dde0ed2f9c28f1935c3c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna try the auto-update you recently added here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about the same.. but then I thought, I need to update the config anyway.. but still.. let me try.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed, unfortunately. https://github.com/elastic/oblt-actions/actions/runs/9859667131

At least, I can try to fix it in this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you able to make the autodiscovery update work in another repo?

I'm wondering if it's failing because it cannot read the oblt-cli/version policy package

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked in elastic/apm-agent-go#1634 when running https://github.com/elastic/apm-agent-go/actions/runs/9809715657 as part of elastic/apm-agent-go#1633, for such I created a feature branch in the upstream

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what's the error about:

⚠ While nothing change in the current pipeline run, according to the git history, some commits must be pushed
ERROR: non-fast-forward update
ERROR: push error: unpack error: index-pack failed

There is a missing piece of configuration:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you can remove the bump and keep the rest of the files so we can test the updatecli itself by running the main branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reakaleek reakaleek requested a review from v1v July 9, 2024 17:02
@reakaleek reakaleek enabled auto-merge (squash) July 10, 2024 08:13
@reakaleek reakaleek merged commit 4e54784 into main Jul 10, 2024
4 checks passed
@reakaleek reakaleek deleted the feature/update-oblt-cli-version-updatecli-policy branch July 10, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:chore When you add a change that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants