[ML] Add unit test checks for new hyperparameters in supervised learning #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
approved these changes
Nov 28, 2019
Co-Authored-By: Tom Veasey <tveasey@users.noreply.github.com>
Co-Authored-By: Tom Veasey <tveasey@users.noreply.github.com>
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Nov 29, 2019
…ing (elastic#855) This PR adds check that user-specified hyperparameters are used as final hyperparameters by the boosted trees. Implementation of the unit test required factoring out classes CBoostedTreeHyperparameters and CBoostedTreeRegularization from CBoostedTreeImpl. Also I added the setting of some user-specified hyperparameters in CBoostedTreeFactory.cc that were missing before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds check that user-specified hyperparameters are used as final hyperparameters by the boosted trees. Implementation of the unit test required factoring out classes
CBoostedTreeHyperparametersandCBoostedTreeRegularizationfromCBoostedTreeImpl.Also I added the setting of some user-specified hyperparameters in
CBoostedTreeFactory.ccthat were missing before.Fixes #851
Fixes #849