Skip to content

[ML] Change brace placement in shell scripts #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2018

Conversation

droberts195
Copy link
Contributor

This changes brace placement for functions in shell scripts to
match the style that was introduced for the C++ code in #15.

This changes brace placement for functions in shell scripts to
match the style that was introduced for the C++ code in elastic#15.
Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One thing I have noticed though is that both these shell scripts share a lot of common functionality - it might be nice to pull that out into a separate module at some point in the future to reduce the effort of maintenance tasks such as this one.

@droberts195 droberts195 merged commit 960ed3c into elastic:master May 2, 2018
@droberts195 droberts195 deleted the brace_format_in_scripts branch May 2, 2018 13:23
droberts195 added a commit that referenced this pull request May 2, 2018
This changes brace placement for functions in shell scripts to
match the style that was introduced for the C++ code in #15.
droberts195 added a commit that referenced this pull request May 2, 2018
This changes brace placement for functions in shell scripts to
match the style that was introduced for the C++ code in #15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants