Skip to content

[ML] Make constants truly constant #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

droberts195
Copy link
Contributor

Follow-on to #102. Fixing more places where pointers intended
to be immutable could be changed to a point at a different
constant.

Follow-on to elastic#102.  Fixing more places where pointers intended
to be immutable could be changed to a point at a different
constant.
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 618d9f1 into elastic:master Feb 21, 2019
@droberts195 droberts195 deleted the make_constants_constant branch February 21, 2019 17:24
droberts195 added a commit to droberts195/ml-cpp that referenced this pull request Feb 21, 2019
Follow-on to elastic#102.  Fixing more places where pointers intended
to be immutable could be changed to a point at a different
constant.

Backport of elastic#409
droberts195 added a commit that referenced this pull request Feb 22, 2019
Follow-on to #102.  Fixing more places where pointers intended
to be immutable could be changed to a point at a different
constant.

Backport of #409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants