[ML] Use nullptr instead of 0 in core lib #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
commented
Apr 4, 2018
lib/core/CThread.cc
Outdated
| @@ -61,25 +61,30 @@ namespace ml | |||
| namespace core | |||
| { | |||
|
|
|||
| #ifdef MacOSX | |||
| CThread::TThreadId CThread::UNALLOCATED_THREAD_ID = nullptr; | |||
There was a problem hiding this comment.
On macos _darwin_pthread_t is defined to be a pointer see /usr/include/sys/_pthread/_pthread_types.h on Linux pthread_t is an arithmetic type.
There was a problem hiding this comment.
I think you could just write this:
CThread::TThreadId CThread::UNALLOCATED_THREAD_ID{};
and avoid the #ifdef.
|
@edsavage could you review this please. Rebasing on the code style commit introduced a lot of chanages |
This was referenced Apr 6, 2018
|
I think it's worth backporting this to 6.3, otherwise it will cause clashes in other backports. |
davidkyle
added a commit
that referenced
this pull request
Apr 9, 2018
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of llvm on macos will warn if
0is used instead ofnullptr(-Wzero-as-null-pointer-constant). GCC already has a similar warning.This PR replaces
0withnullptrI intend to do the entire code base but this change is already large so I will break it up by the libraries.Backport pending