Skip to content

[ML] Guard against possible boost exceptions creating chi distribution #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

[ML] Guard against possible boost exceptions creating chi distribution #23

merged 1 commit into from
Mar 26, 2018

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Mar 23, 2018

This guards all remaining unchecked calls to create a chi distribution with potentially zero degrees freedom. Some of these cases should definitely never happen currently, but it seems that #13 wasn't sufficient to fix #20. In all these cases the behaviour when degrees freedom is zero is clearcut and an always false condition should be very cheap so this change seems prudent. This code has not yet been released so marking as a non-issue.

This should fix #20.

@tveasey tveasey requested a review from hendrikmuhs March 23, 2018 17:00
@tveasey tveasey added the :ml label Mar 23, 2018
hendrikmuhs
hendrikmuhs approved these changes Mar 26, 2018
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey tveasey merged commit 8251de6 into elastic:master Mar 26, 2018
@dolaru dolaru mentioned this pull request Mar 27, 2018
Closed
tveasey added a commit that referenced this pull request Mar 28, 2018
@tveasey
Guard all remaining unguarded calls to create a chi^2 distribution fo…
5807eb8 
…r the case d.f. 0 (#23)

This guards all remaining calls to create a chi^2 distribution in the tests for periodicity to avoid 
creating with zero degrees freedom. Fixes #20.
droberts195 pushed a commit that referenced this pull request Apr 23, 2018
@tveasey
Guard all remaining unguarded calls to create a chi^2 distribution fo…
9e07171 
…r the case d.f. 0 (#23)

This guards all remaining calls to create a chi^2 distribution in the tests for periodicity to avoid 
creating with zero degrees freedom. Fixes #20.
droberts195 pushed a commit that referenced this pull request Apr 23, 2018
@tveasey
Guard all remaining unguarded calls to create a chi^2 distribution fo…
188724f 
…r the case d.f. 0 (#23)

This guards all remaining calls to create a chi^2 distribution in the tests for periodicity to avoid 
creating with zero degrees freedom. Fixes #20.
@davidkyle davidkyle mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Assignees
No one assigned
Labels
:ml >non-issue v6.3.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Degrees of freedom argument errors while running the "gallery" dataset
2 participants
@tveasey @hendrikmuhs