[ML] skip calculation of influencer probabilities if no influences specified #149
Conversation
| @@ -761,6 +761,11 @@ bool CProbabilityAndInfluenceCalculator::calculate( | |||
|
|
|||
| LOG_TRACE(<< "probability = " << probability); | |||
|
|
|||
| if (m_InfluencerProbabilities.empty() == true) { | |||
There was a problem hiding this comment.
I thought our guidelines was to prefer == false to !, but I'm not sure about == true this looks a bit funny to me. Also, I think this can safely go before if (!m_Probability.calculate(probability)) to skip more redundant work; I don't actually think it is appropriate to return false in this case either if that were to fail.
There was a problem hiding this comment.
fair enough, I was unsure myself if I should add the redundant == true, will remove that.
I wonder about the suggestions to move it up, probability is an out parameter and according to my investigations this is important to be calculated independent of influencers.
There was a problem hiding this comment.
I wonder about the suggestions to move it up,
probabilityis an out parameter
Sorry, yes you are completely right I didn't read this carefully.
…ecified (elastic#149) skip calculation of influencer probabilities if no influences specified
…ecified (#149) skip calculation of influencer probabilities if no influences specified
skip calculation of influencer probabilities if no influences specified