Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLQ-ing events that trigger an conditional evaluation error. #16423

Merged
merged 6 commits into from
Oct 2, 2024
Merged

DLQ-ing events that trigger an conditional evaluation error. #16423

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37706b4
[WIP] send if-failed events into DLQ
andsel Jul 12, 2024
86ebc05
[Test] Added test coverage for DLQ insertion in case if failed ifs
andsel Aug 13, 2024
b421e31
Avoid nesting of try-catch related to different aspects, one is colle…
andsel Sep 5, 2024
f537a1e
[doc] updated DLQ guide to cite that can be used also in conditional …
andsel Sep 5, 2024
f890bf0
Fixed log message in case DLQ is enabled
andsel Sep 18, 2024
cda51bb
Fixed typo
andsel Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed log message in case DLQ is enabled
  • Loading branch information
@andsel
andsel committed Sep 18, 2024
commit f890bf00fe51eadc2282b6debe7345dbc21e93cc
29 changes: 21 additions & 8 deletions logstash-core/src/main/java/org/logstash/execution/AbstractPipelineExt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,26 +181,39 @@ public final class LogErrorEvaluationListener implements ConditionalEvaluationLi
@Override
public void notify(ConditionalEvaluationError err) {
lastErrorEvaluationReceived = err.getCause().getMessage();
LOGGER.warn("{}. Event was dropped, enable debug logging to see the event's payload.", lastErrorEvaluationReceived);
if (isDLQEnabled()) {
LOGGER.warn("{}. Failing event was sent to dead letter queue", lastErrorEvaluationReceived);
} else {
LOGGER.warn("{}. Event was dropped, enable debug logging to see the event's payload.", lastErrorEvaluationReceived);
}
LOGGER.debug("Event generating the fault: {}", err.failedEvent().toMap().toString());

// logs the exception at debug level
try (StringWriter sw = new StringWriter(); PrintWriter pw = new PrintWriter(sw)) {
err.printStackTrace(pw);
LOGGER.debug("{}", sw);
} catch (IOException ioex) {
LOGGER.warn("Invalid operation on closing internal resources", ioex);
if (LOGGER.isDebugEnabled()) {
debugLogStackTrace(err);
}

// if pipeline has DLQ enabled, send also there the event
if (javaDlqWriter != null) {
if (isDLQEnabled()) {
try {
javaDlqWriter.writeEntry(err.failedEvent(), "if-statement", "if-statement", "condition evaluation error, " + lastErrorEvaluationReceived);
} catch (IOException ioex) {
LOGGER.error("Can't write in DLQ", ioex);
}
}
}

private boolean isDLQEnabled() {
return javaDlqWriter != null;
}

private void debugLogStackTrace(ConditionalEvaluationError err) {
try (StringWriter sw = new StringWriter(); PrintWriter pw = new PrintWriter(sw)) {
err.printStackTrace(pw);
LOGGER.debug("{}", sw);
} catch (IOException ioex) {
LOGGER.warn("Invalid operation on closing internal resources", ioex);
}
}
}

@JRubyMethod(required = 4)
Expand Down
Loading