fix Settings equality test which broke the PipelineConfig equality #12009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
pushed a commit
to andsel/logstash
that referenced
this pull request
Jun 26, 2020
fix Settings equality test which broke the PipelineConfig equality
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 26, 2020
fix Settings equality test which broke the PipelineConfig equality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PipelineConfig.equalswas callingSettings#eqlbut should be usingSettings#equalswhich wires on the overloadedSettings#==method.The symptom was that when pipeline reloading was triggered, the pipeline would always be reloaded regardless if it changed or not.