add support for api_key in xpack monitoring and management #11864
Conversation
colinsurprenant
changed the title
colinsurprenant
force-pushed
the
xpack_api_key
branch
4 times, most recently
from
544b073 to
dd8f9cb
Compare
There was a problem hiding this comment.
Good work getting this plumbed all the way through. There certainly are layers, and figuring out where they meet and overlap is no trivial task.
I've left a few notes and nitpicks, mostly in the way of readability, but also a couple where I'm not 100% sure we are supporting all of the api_key use-cases (e.g., with cloud_id).
|
@yaauie thanks for the excellent review - I pushed changes related to most of your comments. |
colinsurprenant
changed the title
|
LGTM. |
colinsurprenant
force-pushed
the
xpack_api_key
branch
from
f44711a to
ecff997
Compare
|
merged in master and 7.x (for 7.9) via #11953 |
|
@colinsurprenant @yaauie This one slipped by me, and there is more docs work to be done. Please tag me for review anytime there are docs changes in a PR (like this one) or when more docs might be needed. Thanks! @karenzone - Note to self: Expand security docs to include monitoring and management |
fixes a regression introduced with the api_key support for xpack monitoring and management in elastic#11864 which disabled the possibility to not use any authentication by relying on the default options and only enabling monitoring for example. It now ignores the default username option when no password is explicitly set.
fixes a regression introduced with the api_key support for xpack monitoring and management in #11864 which disabled the possibility to not use any authentication by relying on the default options and only enabling monitoring for example. It now ignores the default username option when no password is explicitly set.
fixes a regression introduced with the api_key support for xpack monitoring and management in #11864 which disabled the possibility to not use any authentication by relying on the default options and only enabling monitoring for example. It now ignores the default username option when no password is explicitly set.
Add support for api_key authentication in xpack monitoring and management.
Relates to #11788
TODO