support quoted plugin option keys #11688
Merged
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinsurprenant
force-pushed
the
plugin_option_string
branch
from
14b8484 to
cf724af
Compare
This was referenced Mar 16, 2020
colinsurprenant
added a commit
that referenced
this pull request
Mar 16, 2020
7.7 clean backport of #11688
colinsurprenant
added a commit
that referenced
this pull request
Mar 16, 2020
7.6 clean backport of #11688
|
Also merged in 7.6 and 7.x (7.7). |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11222
This makes sure that parsed plugins option keys are stripped of their quotes so that the actual key string does not contain quotes. Added related spec (which breaks without the patch).