logstash-input-twitter as a default plugin

[colinsurprenant]

This simply sets "default-plugins": true on the logstash-input-twitter.

This is a followup on #10928 where setting logstash-input-twitter as a default plugin resulted in a build failure. It was reverted for the sake of moving forward the BC builds.

We can now deal with build issues here separately.

[colinsurprenant]

Ah! Great, I can reproduce locally! Onto investigation.

[colinsurprenant]

Can of worms. The twitter gem 5.x.x depends on faraday ~> 0.9.0 but faraday is already resolved to 0.15.4 in logstash Gemfile.lock.

Now, newer twitter gem v6 drops faraday dependency but we have a bunch of monkey patches that probably don't apply anymore on the newer twitter gem version. I removed the monkey patches and specs are passing. Now manually trying to slurp a twitter feed to see it it really works.

[colinsurprenant]

This will be fixed by logstash-plugins/logstash-input-twitter#63

[colinsurprenant]

logstash-input-twitter v4.0.1 was published which fixes the dependency issue and the build is now green.

[danhermann]

LGTM

[colinsurprenant]

@jsvd since this was done in the context of #10928 for 7.3.0 should we still backport this in 7.3.0 ?

[jsvd]

@colinsurprenant yep, let's merge to all: 7.x, 7.3 and 7.2, the plugin is a default one and has been packed with logstash for a long time

[colinsurprenant]

In 7.2 the twitter input was already in the defaults 🤔
backported to 7.3 and 7.x