correctly handle unexecuted downloadEs task #10555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colinsurprenant
commented
Mar 13, 2019
colinsurprenant
commented
- This sets dummy parameters for the downloadEs task when the required version is not found in the versions API which is necessary because the a task parameters are always evaluated regardless if the task is executed or not.
- The downloadEs doFirst will check if the required version was not found and throw and exception but this will happen only if the task is actually executed.
colinsurprenant
force-pushed
the
fixdownload
branch
from
bed67b8 to
eaeefad
Compare
|
rebasing, merging, backports incoming. |
colinsurprenant
added a commit
to colinsurprenant/logstash
that referenced
this pull request
Mar 13, 2019
colinsurprenant
added a commit
that referenced
this pull request
Mar 13, 2019
7.0 clean backport of #10555
colinsurprenant
added a commit
to colinsurprenant/logstash
that referenced
this pull request
Mar 13, 2019
colinsurprenant
added a commit
that referenced
this pull request
Mar 13, 2019
[7.x clean backport of #10555]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.