move download setup code inside the downloadEs task #10547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
approved these changes
Mar 12, 2019
|
The build failure seems unrelated. |
|
jenkins test this again please |
|
I think the build failure is unrelated; I will merge as-is, merge the backports, and chase down the failure momentarily. |
colinsurprenant
added a commit
that referenced
this pull request
Mar 13, 2019
7.x clean backport of #10547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problems solves the RC1 stack build failure where the downloadEs task is not called but the download url setup was done at the top level and was failing with missing version information.