remove exclusive lock for Ruby pipeline initialization #10431
Merged
+6
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yaauie
approved these changes
Feb 12, 2019
colinsurprenant
force-pushed
the
agent_exclusive
branch
from
6341c76 to
cb38ec0
Compare
This was referenced Feb 15, 2019
colinsurprenant
added a commit
that referenced
this pull request
Feb 15, 2019
7.0 clean backport of #10431
colinsurprenant
added a commit
that referenced
this pull request
Feb 16, 2019
7.x clean backport of #10431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on @yaauie config AST thread safety #10415 and deferred refactoring per #10406.
this removes the Agent exclusive lock put in place to serialize initialization of the Pipeline object to prevent a thread safety issue in the config AST which is not needed anymore per above.