rename config option .url and .ca to .hosts and .certificate_authorit #10380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
approved these changes
Feb 4, 2019
| @@ -26,8 +26,8 @@ def additionals_settings(settings) | |||
| settings.register(LogStash::Setting::ArrayCoercible.new("xpack.management.pipeline.id", String, ["main"])) | |||
| settings.register(LogStash::Setting::NullableString.new("xpack.management.elasticsearch.username", "logstash_system")) | |||
| settings.register(LogStash::Setting::NullableString.new("xpack.management.elasticsearch.password")) | |||
| settings.register(LogStash::Setting::ArrayCoercible.new("xpack.management.elasticsearch.url", String, [ "https://localhost:9200" ] )) | |||
There was a problem hiding this comment.
will we need a backport in which we merely deprecate the current behaviour for 6.x (6.7, which is cut tomorrow)
|
@jsvd WDYT for the deprecation? |
|
@colinsurprenant thinking about how users will take their logstash.yml configuration and apply it to 7.0.0 this will present a breaking change without any heads up or message pointing them to the right setting, so having 6.7 deprecate these settings would be ideal. can you please give it a go? |
|
rebasing and merging. |
colinsurprenant
force-pushed
the
elasticsearch_config
branch
from
9e446f4 to
10b9033
Compare
|
unrelated failure #10371 - merging. |
ycombinator
added a commit
to elastic/logstash-docker
that referenced
this pull request
Feb 8, 2019
In keeping with the changes made in elastic/logstash#10380.
ycombinator
added a commit
to elastic/logstash-docker
that referenced
this pull request
Feb 8, 2019
In keeping with the changes made in elastic/logstash#10380.
ycombinator
added a commit
to elastic/logstash-docker
that referenced
this pull request
Feb 8, 2019
In keeping with the changes made in elastic/logstash#10380.
ycombinator
added a commit
to elastic/logstash-docker
that referenced
this pull request
Feb 8, 2019
In keeping with the changes made in elastic/logstash#10380.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the recent Kibana options changes in kibana#29496 we are also changing this options for 7.0.0-beta1.
*.elasticsearch.urlto*.elasticsearch.hosts*.elasticsearch.cato*.elasticsearch.certificate_authorityThis PR has 3 commits; one for the code changes, tests and docs.