Skip to content

Logstash - Plugins - SSL Settings Standardization - Standardize HTTP FILTER settings #14929

Closed
logstash-plugins/logstash-filter-http
#49

Description

This issue should make the plugin SSL settings consistent with the naming convention defined in the meta issue. Missing settings already supported by the plugin's HTTP/TCP client, which only requires small coding changes on the plugin source, should also be added through this issue.

Add and deprecate options to comply with the naming convention

  • none -> ssl_enabled
  • client_cert -> ssl_certificate
  • cacert -> ssl_certificate_authorities
  • client_key -> ssl_key
  • keystore -> ssl_keystore_path
  • keystore_password -> ssl_keystore_password
  • keystore_type -> ssl_keystore_type
  • truststore -> ssl_truststore_path
  • truststore_password -> ssl_truststore_password
  • truststore_type -> ssl_truststore_type

Verify matching settings types, allowed values, and defaults

  • ssl_supported_protocols
  • ssl_verification_mode

Add common settings validations

  • Not allow mixing the same deprecated and new setting on the same plugin configuration, e.g. ssl and ssl_enabled

Add ssl_verification_mode functionality and mark ssl_certificate_verification as deprecated

  • Make it in a backward-compatible way

Add missing settings/functionality that fits into the phase 1 description, and move non-phase 1-2 to the phase 3 issue (to be created if doesn't exist)

  • ssl_enabled
  • ssl_cipher_suites
  • ssl_handshake_timeout
  • ssl_key_passphrase
  • ssl_keystore_key_password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions