Skip to content

Logstash - Plugins - SSL Settings Standardization - Standardize TCP INPUT settings #14927

Closed
logstash-plugins/logstash-input-tcp
#213

Description

This issue should make the plugin SSL settings consistent with the naming convention defined in the meta issue. Missing settings already supported by the plugin's HTTP/TCP client, which only requires small coding changes on the plugin source, should also be added through this issue.

Add and deprecate options to comply with the naming convention

  • ssl_cert -> ssl_certificate
  • ssl_verify -> ssl_verification_mode

Add ssl_verification_mode functionality and mark ssl_verify as deprecated

  • It currently accepts a boolean, make it backwards compatible

Add common settings validations

  • Not allow mixing the same deprecated and new setting on the same plugin configuration, e.g. ssl_cert and ssl_certificate

Verify matching settings types, allowed values, defaults

  • ssl_enabled
  • ssl_certificate_authorities
  • ssl_cipher_suites
  • ssl_key
  • ssl_key_passphrase
  • ssl_supported_protocols

Add missing settings/functionality that fits into the phase 1 description, and move non-phase 1-2 to the phase 3 issue (to be created if doesn't exist)

  • ssl_client_authentication
  • ssl_handshake_timeout
  • ssl_keystore_path
  • ssl_keystore_password
  • ssl_keystore_type
  • ssl_keystore_key_password
  • ssl_truststore_path
  • ssl_truststore_password
  • ssl_truststore_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions