A connection to ES on cloud with param fix.

[mashhurs]

Description

A connection to ES on cloud with cloud_auth option is raising an exception of [HTTP/1.1 401 Unauthorized]. This change properly sets the username and password in the credentials and establishes successful connection to ES on cloud.

• Closes cloud_auth unable to authenticate #57

[mashhurs]

This will be moved to 0.0.3 once we release after #51 merge.

[yaauie]

I am hesitant to pull unrelated extra bits from Elasticsearch in because although they are likely-stable, they are internal implementation details of Elasticsearch.

[yaauie]

An alternative that doesn't rely on Elasticsearch internals, using com.google.common.base.Strings#isNullOrEmpty(String) from the guava we already explicitly depend on:

Suggested change

	final int colonIndex = cloudAuth.getPassword().indexOf(":");
	if (colonIndex <= 0) {
	throw new IllegalArgumentException("Invalid cloudAuth.");
	}
	String username = cloudAuth.getPassword().substring(0, colonIndex);
	String password = cloudAuth.getPassword().substring(colonIndex + 1);
	Strings.requireNonEmpty(username, "cloudAuth username");
	Strings.requireNonEmpty(password, "cloudAuth password");
	final String cloudAuthValue = cloudAuth.getValue();
	final int colonIndex = cloudAuthValue.indexOf(":");
	final String username;
	final String password;
	if ((colonIndex <= 0)
	|| isNullOrEmpty(username = cloudAuthValue.substring(0, colonIndex))
	|| isNullOrEmpty(password = cloudAuthValue.substring(colonIndex + 1))) {
	throw new IllegalArgumentException("Invalid cloudAuth.");
	}

[mashhurs]

ES Strings is in common (kind of util) which would less likely change (and have IngestDocument, etc dependencies) but as we have a guava for these kinds of operations, updated it with recent commit.

[yaauie]

ES Strings is in common (kind of util) which would less likely change (and have IngestDocument, etc dependencies) but as we have a guava for these kinds of operations

Yes; it is on our class-path as a transitive dependency of one or more Elasticsearch bits that we directly depend on, and is likely-stable, but we don't need to increase our cross-ties.