caching-resolvers: add cache reloader and reloading service #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extends cache TTL for both hits and misses to 24 hours, and adds a pair of reloading services to allow cached entries to be updated as frequently as once per minute. This ensures changes are picked up quickly, while allowing this plugin to survive a period of ES downtime by using possibly-stale values.
jsvd
reviewed
Apr 24, 2023
src/main/java/co/elastic/logstash/filters/elasticintegration/EventProcessorBuilder.java
Outdated
Show resolved
Hide resolved
jsvd
reviewed
Apr 24, 2023
| // start reload services for our resolvers | ||
| final ArrayList<Service> services = new ArrayList<>(); | ||
| eventToPipelineNameResolver.innerCacheReloader().ifPresent(cacheReloader -> { | ||
| final AbstractScheduledService.Scheduler pipelineNameReloadSchedule = newFixedRateSchedule(Duration.ofSeconds(60), Duration.ofSeconds(60)); |
There was a problem hiding this comment.
Same comment here wrt abstracting Duration.ofSeconds(60).
There was a problem hiding this comment.
Similarly, DRYing this to a constant would be trivial.
The AbstractScheduledService#newFixedSchedule differentiates between initial-delay and frequency, so there isn't really a way to simplify this interface.
jsvd
reviewed
Apr 24, 2023
src/main/java/co/elastic/logstash/filters/elasticintegration/resolver/SimpleResolverCache.java
Show resolved
Hide resolved
jsvd
reviewed
Apr 24, 2023
src/main/java/co/elastic/logstash/filters/elasticintegration/resolver/SimpleResolverCache.java
Show resolved
Hide resolved
jsvd
reviewed
Apr 24, 2023
jsvd
approved these changes
Apr 28, 2023
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends cache TTL for both hits and misses to 24 hours, and adds a pair of reloading services to allow cached entries to be updated as frequently as once per minute.
This ensures changes are picked up quickly, while allowing this plugin to survive a period of ES downtime by using possibly-stale values.
Because reloading is also done out-of-band, the event processor no longer is at risk of pausing to load a pipeline that hadn't changed simply because our cache ttl had expired.