Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GeoIpDatabaseProvider#build public to accommodate JRuby package-private method visibility #132

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Feb 28, 2024

Fix for CI failure at runtime: https://buildkite.com/elastic/logstash-serverless-integration-testing/builds/299#018de5b0-39b0-49f3-a295-d15475281758/1258-1265

likely due to JRuby 9.4.6.0 change:

  • Starting with Java 17, package-private methods will no longer be bound automatically even if they can be made visible. #8061, #8093

jruby/jruby#8093

@jsvd jsvd requested a review from yaauie February 28, 2024 10:42
@jsvd jsvd changed the title Update GeoIpDatabaseProvider.java Make GeoIpDatabaseProvider#build public to accommodate JRuby package-private method visibility Feb 28, 2024
@jsvd jsvd marked this pull request as ready for review February 28, 2024 14:03
@yaauie
Copy link
Member

yaauie commented Feb 28, 2024

Good catch. We will need a changelog entry and a version bump. Release can likely wait until we have a feature or get closer to a release of Logstash that includes the affected Jruby.

@jsvd
Copy link
Member Author

jsvd commented Feb 29, 2024

@logstashmachine bump patch

1 similar comment
@jsvd
Copy link
Member Author

jsvd commented Mar 4, 2024

@logstashmachine bump patch

@jsvd
Copy link
Member Author

jsvd commented Mar 4, 2024

Good catch. We will need a changelog entry and a version bump. Release can likely wait until we have a feature or get closer to a release of Logstash that includes the affected Jruby.

@yaauie done! If possible I'd rather publish this ASAP as it's breaking current serverless integration tests with Logstash main (already on 9.4.6.0).

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@yaauie yaauie merged commit d312d63 into main Mar 5, 2024
4 checks passed
@yaauie yaauie deleted the jsvd-patch-1 branch March 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants