fix: preemptively send basic auth #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Elasticsearch is configured to allow anonymous auth, it does not include a challenge header in response to requests, so we cannot rely on the apache http client's auth handling (which is overkill anyway, since an individual Elasticsearch client is not connected to multiple realms). Instead, we build the http basic auth header ourselves, and register an interceptor to ensure it is added to all requests, similar to how we handle api key auth headers.
mashhurs
previously approved these changes
Feb 8, 2024
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
💔 Build Failed
Failed CI Steps
History
|
|
Buildkite failed because it is trying to build against Elasticsearch 8.13's source, but the 8.13 branch has not yet been cut. When building against Elasticsearch 8.11's source (as done in our gradle tasks for building and releasing the artifact), tests succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Elasticsearch is configured to allow anonymous auth, it does not include a challenge header in response to requests, so we cannot rely on the apache http client's auth handling (which is overkill anyway, since an individual Elasticsearch client is not connected to multiple realms).
Instead, we build the http basic auth header ourselves, and register an interceptor to ensure it is added to all requests, similar to how we handle api key auth headers.