Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix package category count #99677

Merged
merged 4 commits into from
May 12, 2021
Merged

[Fleet] Fix package category count #99677

merged 4 commits into from
May 12, 2021

Conversation

nchaulet
Copy link
Member

Summary

Resolve #94582

Blocked on elastic/package-registry#695

Currently the package count in the EPM screen could be wrong.

https://user-images.githubusercontent.com/36789353/111175378-a7bb4500-85a8-11eb-8829-4b3dc521e95d.png because we are not filtering the packages based on the

This is happening because we are not filtering packages based on Kibana version in the package registry /categories endpoint that PR add the parameter to the endpoint call as it's done for the/search endpoint

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 10, 2021
@nchaulet nchaulet self-assigned this May 10, 2021
@nchaulet nchaulet requested a review from a team as a code owner May 10, 2021 19:04
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 9907903 into elastic:master May 12, 2021
@nchaulet nchaulet deleted the fix-94582-category-count branch May 12, 2021 13:47
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 12, 2021
@nchaulet @kibanamachine
[Fleet] Fix package category count (elastic#99677)
083b871
@kibanamachine kibanamachine mentioned this pull request May 12, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 12, 2021
@nchaulet @kibanamachine
[Fleet] Fix package category count (elastic#99677)
a2c3317
@kibanamachine kibanamachine mentioned this pull request May 12, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 12, 2021
@kibanamachine @nchaulet
[Fleet] Fix package category count (#99677) (#99924)
bf720ce 
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
kibanamachine added a commit that referenced this pull request May 12, 2021
@kibanamachine @nchaulet
[Fleet] Fix package category count (#99677) (#99925)
975ea63 
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfsiii jfsiii jfsiii approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Incorrect category count displayed
4 participants
@nchaulet @elasticmachine @kibanamachine @jfsiii