[ML] Transforms: Fix transform id validation to use RegExp used in ES code. #98783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
Contributor
|
Pinging @elastic/ml-ui (:ml) |
walterra
added
the
release_note:skip
qn895
approved these changes
Apr 29, 2021
Member
|
LGTM 🎉 |
2 tasks
walterra
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 30, 2021
…tic#98783) Fixes isTransformIdValid() to use the same RegExp used in Elasticsearch's transform code.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 30, 2021
…tic#98783) Fixes isTransformIdValid() to use the same RegExp used in Elasticsearch's transform code.
Contributor
kibanamachine
added a commit
that referenced
this pull request
Apr 30, 2021
…) (#98894) Fixes isTransformIdValid() to use the same RegExp used in Elasticsearch's transform code. Co-authored-by: Walter Rafelsberger <walter@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Apr 30, 2021
…) (#98895) Fixes isTransformIdValid() to use the same RegExp used in Elasticsearch's transform code. Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #80650.
Fixes
isTransformIdValid()to use the same RegExp used in Elasticsearch's transform code.Checklist