-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Data Frame Analytics: Fix special character escaping for Vega scatterplot matrix. #98763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Frame Analytics: Fix special character escaping for Vega scatterplot matrix. #98763
Conversation
|
Pinging @elastic/ml-ui (:ml) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
This looks like an issue with the Gives the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM. Will follow up the issue around the _explain endpoint separately (raised elastic/elasticsearch#72541)
…atterplot matrix. (elastic#98763) - Fixes correctly escaping the characters .[] in field names with double backslashes since Vega treats dots/brackets in field names special to be able to access attributes in object structures. This replaces the old approach that replaced dots with a similar but different UTF-8 character but missed the brackets. - Additionally adds an EuiErrorBoundary component around the VegaChart component so we don't crash the whole page should another issue with Vega bubble up.
…atterplot matrix. (elastic#98763) - Fixes correctly escaping the characters .[] in field names with double backslashes since Vega treats dots/brackets in field names special to be able to access attributes in object structures. This replaces the old approach that replaced dots with a similar but different UTF-8 character but missed the brackets. - Additionally adds an EuiErrorBoundary component around the VegaChart component so we don't crash the whole page should another issue with Vega bubble up.
…atterplot matrix. (#98763) (#98891) - Fixes correctly escaping the characters .[] in field names with double backslashes since Vega treats dots/brackets in field names special to be able to access attributes in object structures. This replaces the old approach that replaced dots with a similar but different UTF-8 character but missed the brackets. - Additionally adds an EuiErrorBoundary component around the VegaChart component so we don't crash the whole page should another issue with Vega bubble up. Co-authored-by: Walter Rafelsberger <walter@elastic.co>
…atterplot matrix. (#98763) (#98893) - Fixes correctly escaping the characters .[] in field names with double backslashes since Vega treats dots/brackets in field names special to be able to access attributes in object structures. This replaces the old approach that replaced dots with a similar but different UTF-8 character but missed the brackets. - Additionally adds an EuiErrorBoundary component around the VegaChart component so we don't crash the whole page should another issue with Vega bubble up. Co-authored-by: Walter Rafelsberger <walter@elastic.co>

Summary
Fixes #96609.
.[]in field names with double backslashes since Vega treats dots/brackets in field names special to be able to access attributes in object structures. See https://vega.github.io/vega-lite/docs/field.html for details. This replaces the old approach that replaced dots with a similar but different UTF-8 character but missed the brackets.EuiErrorBoundarycomponent around theVegaChartcomponent so we don't crash the whole page should another issue with Vega bubble up.vega-litewhich renders escaping backslashes in axis and legend titles, I created a bug report here.Checklist